Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate cost and tokens #1740

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Propagate cost and tokens #1740

merged 9 commits into from
Jun 10, 2024

Conversation

mmabrouk
Copy link
Member

@mmabrouk mmabrouk commented Jun 2, 2024

Modifies the SDK to propagate the cost and tokens along the tree.
Untested. Please QA

@vercel Vercel
Copy link

vercel bot commented Jun 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 0:21am

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 2, 2024
@mmabrouk mmabrouk requested a review from aybruhm June 2, 2024 17:57
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 5, 2024
aybruhm
aybruhm requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @mmabrouk. I noticed that the tokens type was incorrect, so I corrected it to its proper type.

Also, upon reviewing the PR, I found an issue with the propagation. Please see the details below:

image

@mmabrouk
Copy link
Member Author

mmabrouk commented Jun 6, 2024

Thanks for the review @aybruhm . I have fixed the issue.

@mmabrouk mmabrouk requested a review from aybruhm June 6, 2024 18:41
@mmabrouk
Copy link
Member Author

mmabrouk commented Jun 9, 2024

@aybruhm I think you've missed this. The PR is ready for review.

aybruhm
aybruhm approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work, @mmabrouk!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 10, 2024
@mmabrouk mmabrouk merged commit 03d1d69 into main Jun 10, 2024
9 checks passed
@mmabrouk mmabrouk deleted the update-cost-span branch June 10, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybruhm aybruhm aybruhm approved these changes

Assignees
No one assigned
Labels
CLI lgtm This PR has been approved by a maintainer SDK size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmabrouk @aybruhm